-
Notifications
You must be signed in to change notification settings - Fork 17
Added benchmarks for plots #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 11 11
Lines 1745 1745
=======================================
Hits 1402 1402
Misses 343 343 |
you mean for the token? |
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
Good news I setup everything. Bad news, CodSpeed doesn't seem to be suitable for the benchmarking use cases of See for example this screenshot; the execution time for I wrote to the devs to see if there is an option to get around this, but most likely I'll end up closing this PR and switching to EDIT: gonna close the PR already, wait for an answer and unless we can go back to CodSpeed, we can proceed with airspeed velocity (asv). |
I archived the branch behind this PR here https://github.com/scverse/spatialdata-plot/releases/tag/archive%2Fcodspeed_benchmarks, I'll delete this branch. |
I added some basic sets of benchmarks for measuring the time to produce plots. The correctness of the plots is currently not checked, we can modify it later.
The only thing missing from the PR is the integration with GitHub Actions, so that we will catch on time eventual future performance drops. To finalize that I need some permissions from scverse.