Fix server version matching logic on integration suite #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
requested changes
May 9, 2025
Collaborator
dkropachev
left a comment
dkropachev
left a comment
There was a problem hiding this comment.
Please fix CassandraVersionString to return particular version when SCYLLA_VERSION is present.
Remove scyllaVersion from CcmCluster, use version for that, add BackendType to class attirbutes
src/Cassandra.IntegrationTests/TestClusterManagement/TestClusterManager.cs
Outdated
Show resolved
Hide resolved
dkropachev
requested changes
May 9, 2025
sylwiaszunejko
force-pushed
the
fix_server_version
branch
3 times, most recently
from
51a2f80 to
8ed3196
Compare
dkropachev
reviewed
May 13, 2025
src/Cassandra.IntegrationTests/TestClusterManagement/CcmBridge.cs
Outdated
Show resolved
Hide resolved
src/Cassandra.IntegrationTests/TestClusterManagement/TestClusterManager.cs
Outdated
Show resolved
Hide resolved
src/Cassandra.IntegrationTests/TestClusterManagement/TestClusterManager.cs
Outdated
Show resolved
Hide resolved
sylwiaszunejko
force-pushed
the
fix_server_version
branch
2 times, most recently
from
655d613 to
9501d45
Compare
dkropachev
requested changes
May 14, 2025
sylwiaszunejko
force-pushed
the
fix_server_version
branch
from
9501d45 to
bd3bc65
Compare
dkropachev
force-pushed
the
fix_server_version
branch
from
7cea300 to
927390c
Compare
sylwiaszunejko
force-pushed
the
fix_server_version
branch
from
927390c to
fc56844
Compare
dkropachev
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20