Skip to content

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Oct 12, 2025

List of changes:

  1. Enable pp wheels, new version requires them to be specifically enabled
  2. Remove CIBW_BUILD and CIBW_SKIP from test disabling stage, now these parameters are not getting overwritten.
  3. Remove skipping patterns for python 2, 3.6, 3.7, they are no supported by this version of cibuildwheel.
  4. Added skip pattern for freethread python.
  5. Remove override that disables tests for pypy, now they are not failing.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev dkropachev force-pushed the dk/update-cibuildwheel branch from ff9a771 to 8b7d94e Compare October 12, 2025 15:06
@dkropachev dkropachev requested a review from Lorak-mmk October 12, 2025 15:07
@dkropachev dkropachev self-assigned this Oct 12, 2025
@dkropachev dkropachev marked this pull request as ready for review October 12, 2025 15:16
@dkropachev dkropachev requested a review from fruch October 12, 2025 15:16
@dkropachev dkropachev force-pushed the dk/update-cibuildwheel branch 3 times, most recently from ec80529 to c14f7f7 Compare October 12, 2025 22:52
@dkropachev dkropachev marked this pull request as draft October 12, 2025 22:53
@dkropachev dkropachev force-pushed the dk/update-cibuildwheel branch 3 times, most recently from b573860 to a5633e8 Compare October 13, 2025 17:45
@dkropachev dkropachev marked this pull request as ready for review October 13, 2025 19:44
@dkropachev dkropachev force-pushed the dk/update-cibuildwheel branch from a5633e8 to e5f1135 Compare October 13, 2025 19:46
@dkropachev dkropachev force-pushed the dk/update-cibuildwheel branch from e5f1135 to 1815497 Compare October 14, 2025 12:10
New version does not support pypy wheels, so just remove them.
Also new version does not support cp2* cp36* and cp37* builds anymore,
so we can safely drop them.
Exclude building freethreaded python wheels.
@dkropachev dkropachev force-pushed the dk/update-cibuildwheel branch from 1815497 to cee2a24 Compare October 14, 2025 17:02
@dkropachev dkropachev requested a review from Lorak-mmk October 14, 2025 17:09
Copy link

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkropachev dkropachev merged commit 38816d8 into scylladb:master Oct 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants