forked from datastax/python-driver
-
Notifications
You must be signed in to change notification settings - Fork 49
tests: drop sure package
#592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
fd03b37 to
b80d09c
Compare
Collaborator
Author
|
CICD is failing on one test, it is not caused by this PR, there is a separate issue on that: #591 |
Lorak-mmk
requested changes
Nov 16, 2025
946f0e9 to
afc3138
Compare
This package colides with twisted implementation, which ends up in the
following error:
```
File "/home/runner/work/python-driver/python-driver/.venv/lib/python3.11/site-packages/sure/__init__.py", line 1084, in _new_dir
patched = [x for x in old_dir(obj[0]) if isinstance(getattr(obj[0], x, None), AssertionBuilder)]
File "/home/runner/work/python-driver/python-driver/.venv/lib/python3.11/site-packages/sure/__init__.py", line 1084, in <listcomp>
patched = [x for x in old_dir(obj[0]) if isinstance(getattr(obj[0], x, None), AssertionBuilder)]
File "/home/runner/work/python-driver/python-driver/.venv/lib/python3.11/site-packages/zope/interface/ro.py", line 224, in __get__
for k in dir(klass):
File "/home/runner/work/python-driver/python-driver/.venv/lib/python3.11/site-packages/sure/__init__.py", line 1084, in _new_dir
patched = [x for x in old_dir(obj[0]) if isinstance(getattr(obj[0], x, None), AssertionBuilder)]
builtins.RecursionError: maximum recursion depth exceeded while calling a Python object
```
afc3138 to
6de7372
Compare
fruch
approved these changes
Nov 16, 2025
fruch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sylwiaszunejko
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package colides with twisted implementation, which ends up in the following error:
Fixes: #589
Pre-review checklist
I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.Fixes:annotations to PR description.