Skip to content

[FEATURE, BREAKING] Support for extensible-format WAVE files #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2025
Merged

[FEATURE, BREAKING] Support for extensible-format WAVE files #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e7101b
Formatting
sdatkinson May 10, 2025
e08ebd3
Refactored wav.cpp. Should function the same as before.
sdatkinson May 10, 2025
e688e28
Implement support for extensible-format WAVE files that are PCM or IEEE
sdatkinson May 10, 2025
5cdf059
Remove debugging lines
sdatkinson May 10, 2025
d070160
Bump minor version for breaking change
sdatkinson May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dsp/NoiseGate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class TriggerParams
, mRatio(ratio)
, mOpenTime(openTime)
, mHoldTime(holdTime)
, mCloseTime(closeTime){};
, mCloseTime(closeTime) {};

double GetTime() const { return this->mTime; };
double GetThreshold() const { return this->mThreshold; };
Expand Down
16 changes: 8 additions & 8 deletions dsp/RecursiveLinearFilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class LevelParams : public dsp::Params
public:
LevelParams(const double gain)
: Params()
, mGain(gain){};
, mGain(gain) {};
double GetGain() const { return this->mGain; };

private:
Expand All @@ -68,7 +68,7 @@ class Level : public Base
{
public:
Level()
: Base(1, 0){};
: Base(1, 0) {};
// Invalid usage: require a pointer to recursive_linear_filter::Params so
// that SetCoefficients() is defined.
void SetParams(const LevelParams& params) { this->mInputCoefficients[0] = params.GetGain(); };
Expand All @@ -85,7 +85,7 @@ class BiquadParams : public dsp::Params
, mFrequency(frequency)
, mGainDB(gainDB)
, mQuality(quality)
, mSampleRate(sampleRate){};
, mSampleRate(sampleRate) {};

// Parameters defined in
// https://webaudio.github.io/Audio-EQ-Cookbook/audio-eq-cookbook.html
Expand All @@ -105,7 +105,7 @@ class Biquad : public Base
{
public:
Biquad()
: Base(3, 3){};
: Base(3, 3) {};
virtual void SetParams(const BiquadParams& params) = 0;

protected:
Expand Down Expand Up @@ -139,7 +139,7 @@ class HighPassParams : public dsp::Params
HighPassParams(const double sampleRate, const double frequency)
: dsp::Params()
, mFrequency(frequency)
, mSampleRate(sampleRate){};
, mSampleRate(sampleRate) {};

double GetAlpha() const
{
Expand All @@ -156,7 +156,7 @@ class HighPass : public Base
{
public:
HighPass()
: Base(2, 2){};
: Base(2, 2) {};
void SetParams(const HighPassParams& params)
{
const double alpha = params.GetAlpha();
Expand All @@ -174,7 +174,7 @@ class LowPassParams : public dsp::Params
LowPassParams(const double sampleRate, const double frequency)
: dsp::Params()
, mFrequency(frequency)
, mSampleRate(sampleRate){};
, mSampleRate(sampleRate) {};

double GetAlpha() const
{
Expand All @@ -191,7 +191,7 @@ class LowPass : public Base
{
public:
LowPass()
: Base(1, 2){};
: Base(1, 2) {};
void SetParams(const LowPassParams& params)
{
const double alpha = params.GetAlpha();
Expand Down
2 changes: 1 addition & 1 deletion dsp/version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define version_h

#define AUDIO_DSP_TOOLS_VERSION_MAJOR 0
#define AUDIO_DSP_TOOLS_VERSION_MINOR 0
#define AUDIO_DSP_TOOLS_VERSION_MINOR 1
#define AUDIO_DSP_TOOLS_VERSION_PATCH 0

#endif
Loading
Loading