Skip to content

Task/improve searching in manifest files#37

Merged
sdex merged 14 commits intosdex:masterfrom
Y-E-P:task/Improve_searching_in_manifest_files
Apr 17, 2023
Merged

Task/improve searching in manifest files#37
sdex merged 14 commits intosdex:masterfrom
Y-E-P:task/Improve_searching_in_manifest_files

Conversation

@Y-E-P
Copy link
Copy Markdown
Contributor

@Y-E-P Y-E-P commented Apr 10, 2023

Added library and make simple implementation including back pressed action.

Y-E-P added 2 commits April 12, 2023 21:42
* added new background and removed view with 1dp as divider
@sdex
Copy link
Copy Markdown
Owner

sdex commented Apr 13, 2023

Everything looks great so far. There is just one thing left - saving state.
After rotating the screen the webview saves and highlights the search result but the search bar is gone.

@Y-E-P
Copy link
Copy Markdown
Contributor Author

Y-E-P commented Apr 13, 2023

Everything looks great so far. There is just one thing left - saving state. After rotating the screen the webview saves and highlights the search result but the search bar is gone.

Good point, let me check it and fix

Copy link
Copy Markdown
Owner

@sdex sdex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@sdex sdex merged commit 43043e3 into sdex:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants