Skip to content

Ok cancel editwidget#127

Merged
sdorra merged 1 commit intoangular-dashboard-framework:masterfrom
dulcedilip:ok-cancel-editwidget
Jul 30, 2015
Merged

Ok cancel editwidget#127
sdorra merged 1 commit intoangular-dashboard-framework:masterfrom
dulcedilip:ok-cancel-editwidget

Conversation

@dulcedilip
Copy link
Copy Markdown

ok-cancel in widget level,while updating the existing widgets user can cancel or save his changes.

editScope.definition = angular.copy(definition); 

note: added saveDialog function which will save his changes to adf

editScope.saveDialog = function() {
definition.title = editScope.definition.title;
angular.extend(definition.config,editScope.definition.config); 
editScope.closeDialog();
};

@supersonicclay
Copy link
Copy Markdown

+1
I agree with this change of functionality. A quick cancel in the edit dialog will be helpful to users.

@dulcedilip dulcedilip force-pushed the ok-cancel-editwidget branch from b041b23 to 2947002 Compare July 28, 2015 20:49
@sdorra sdorra self-assigned this Jul 30, 2015
sdorra added a commit that referenced this pull request Jul 30, 2015
@sdorra sdorra merged commit e9c1ec3 into angular-dashboard-framework:master Jul 30, 2015
@sdorra
Copy link
Copy Markdown
Member

sdorra commented Jul 30, 2015

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants