Skip to content

Adding nested rows#52

Merged
sdorra merged 6 commits intoangular-dashboard-framework:masterfrom
Fationably-Late:master
Jan 10, 2015
Merged

Adding nested rows#52
sdorra merged 6 commits intoangular-dashboard-framework:masterfrom
Fationably-Late:master

Conversation

@Fationably-Late
Copy link
Copy Markdown
Contributor

Since I didn't see any movement on issue #33 , I decided to go ahead and create something and share it with you guys and perhaps get it added to the core project.

I added 2 small directives (adfDashboardRow & adfDashboardColumn) for recursively adding rows and columns while maintaining scope. I also modified the existing readColumns() and fillStructure() methods in the adfDashboard directive.

An example structure object will look something like this:

{
        "rows": [
            {
                "columns": [
                    {
                        "styleClass": "col-md-2",
                        "widgets": []
                    },
                    {
                        "styleClass": "col-md-10",
                        "widgets": [],
                        "rows": [
                            {
                                "columns": [
                                    {
                                        "styleClass": "col-md-12",
                                        "widgets": []
                                    }
                                ]
                            },
                            {
                                "columns": [
                                    {
                                        "styleClass": "col-md-6",
                                        "widgets": []
                                    },
                                    {
                                        "styleClass": "col-md-6",
                                        "widgets": []
                                    }
                                ]
                            },
                            {
                                "columns": [
                                    {
                                        "styleClass": "col-md-12",
                                        "widgets": []
                                    }
                                ]
                            }
                        ]
                    }
                ]
            }
        ]
    }

with a rows property in each columns definition on the same level as styleClass and widgets.

Please review and critique as needed. Everything is working on my end, but I've been staring at it for a while and may have missed something. :)

@sdorra
Copy link
Copy Markdown
Member

sdorra commented Jan 10, 2015

This looks very promising, but the sample (grunt server - http://localhost:9001/sample) seems not to work anymore. No widgets are visible and the edit mode does not work.

@sdorra sdorra self-assigned this Jan 10, 2015
@Fationably-Late
Copy link
Copy Markdown
Contributor Author

Oops. You're right, I only edited the src files. I'll commit something soon that fixes it. Sorry about that.

sdorra added a commit that referenced this pull request Jan 10, 2015
@sdorra sdorra merged commit 1aa0138 into angular-dashboard-framework:master Jan 10, 2015
@sdorra
Copy link
Copy Markdown
Member

sdorra commented Jan 10, 2015

thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants