Adding nested rows#52
Merged
sdorra merged 6 commits intoangular-dashboard-framework:masterfrom Jan 10, 2015
Fationably-Late:master
Merged
Adding nested rows#52sdorra merged 6 commits intoangular-dashboard-framework:masterfrom Fationably-Late:master
sdorra merged 6 commits intoangular-dashboard-framework:masterfrom
Fationably-Late:master
Conversation
Member
|
This looks very promising, but the sample (grunt server - http://localhost:9001/sample) seems not to work anymore. No widgets are visible and the edit mode does not work. |
Contributor
Author
|
Oops. You're right, I only edited the |
Member
|
thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I didn't see any movement on issue #33 , I decided to go ahead and create something and share it with you guys and perhaps get it added to the core project.
I added 2 small directives (
adfDashboardRow&adfDashboardColumn) for recursively adding rows and columns while maintaining scope. I also modified the existingreadColumns()andfillStructure()methods in theadfDashboarddirective.An example structure object will look something like this:
{ "rows": [ { "columns": [ { "styleClass": "col-md-2", "widgets": [] }, { "styleClass": "col-md-10", "widgets": [], "rows": [ { "columns": [ { "styleClass": "col-md-12", "widgets": [] } ] }, { "columns": [ { "styleClass": "col-md-6", "widgets": [] }, { "styleClass": "col-md-6", "widgets": [] } ] }, { "columns": [ { "styleClass": "col-md-12", "widgets": [] } ] } ] } ] } ] }with a
rowsproperty in eachcolumnsdefinition on the same level asstyleClassandwidgets.Please review and critique as needed. Everything is working on my end, but I've been staring at it for a while and may have missed something. :)