Add pre-push hook to run RSpec test suite

[jawshooah]

Add an opt-in hook to run rspec before push.

It would be great to enable live terminal output during the hook run to show progress, but I'm not sure how we would go about that with the current framework.

Also, if individual tests write to stderr, then simply concatenating stdout with stderr doesn't preserve the interleaving and isn't an accurate portrayal of the actual output. Again, not sure how to fix this.

[sds]

Since you aren't returning any line information, you can simplify this to:

[:fail, output]

[jawshooah]

Ah, I thought that form was deprecated.

[sds]

Live streaming of terminal output would be quite the undertaking, especially since we want to move towards parallelized hook runs at some point. The complexity it would introduce would also be something I'd rather not introduce if we don't have to.

[jawshooah]

True, probably not worth the effort or complexity. And I guess there's really no other way to preserve the order of messages printed to stdout and stderr.

With that in mind, do you think it would be better to show only one or the other, rather than concatenating the two? E.g. if stdout is non-empty, ignore stderr.

[sds]

I think it depends on the tool. I'm not familiar with when RSpec outputs to stdout versus stderr. I think we should output whatever information is most informative in helping the developer fix the problem.

Thanks for the feature!