Skip to content

Conversation

@jawshooah
Copy link
Collaborator

These hooks warn of any submodules that are uninitialized, out of date with the current index, or contain merge conflicts.

To check submodules recursively, just set flags: ['--recursive'] in the config.

Closes #145

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're duplicating this helper Struct across each of these hooks, and since submodules are a git primitive of sorts, it seems appropriate to extract the regex, struct, and helpers into the GitRepo module. That would allow us to DRY up a lot of this.

What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I've extracted the regex, struct, and helper to GitRepo. Also made recursive a config setting.

@sds sds added the enhancement label Apr 7, 2015
@sds
Copy link
Owner

sds commented Apr 7, 2015

Thanks!

@sds sds closed this Apr 7, 2015
@jawshooah jawshooah deleted the post-checkout/submodule-status branch April 7, 2015 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add post-checkout hook to remind user to update submodules

2 participants