Skip to content

Extract process logic from Utils.execute_in_background into Subprocess.spawn_detached #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Extract process logic from Utils.execute_in_background into Subprocess.spawn_detached #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fe6a3f
Add method Subprocess#spawn_in_background
jawshooah Apr 7, 2015
9648d3a
Defer to Subprocess for process spawning logic
jawshooah Apr 7, 2015
6ef71ed
Use Process.detach to run process in the background
jawshooah Apr 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/overcommit/subprocess.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ def spawn(args)
Result.new(process.exit_code, out.read, err.read)
end

# Spawns a new process in the background using the given array of
# arguments (the first element is the command).
def spawn_detached(args)
# Dissociate process from parent's input/output streams
Process.detach(Process.spawn({}, *args, [:in, :out, :err] => '/dev/null'))
end

private

# @param process [ChildProcess]
Expand Down
3 changes: 1 addition & 2 deletions lib/overcommit/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,7 @@ def execute_in_background(args)
'Cannot pipe commands with the `execute_in_background` helper'
end

# Dissociate process from parent's input/output streams
Process.detach(Process.spawn({}, *args, [:in, :out, :err] => '/dev/null'))
Subprocess.spawn_detached(args)
end

# Calls a block of code with a modified set of environment variables,
Expand Down