Skip to content

Fix parsing of reek output for newer versions of reek #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix parsing of reek output for newer versions of reek #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/overcommit/hook/pre_commit/reek.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def run

extract_messages(
output,
/^(?<file>[^:]+):(?<line>\d+):/,
/^\s*(?<file>[^:]+):(?<line>\d+):/,
)
end

Expand Down
34 changes: 27 additions & 7 deletions spec/overcommit/hook/pre_commit/reek_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,35 @@
end

context 'and it reports warnings' do
before do
result.stub(:stdout).and_return([
'file1.rb -- 1 warning:',
'file1.rb:1: MyClass#my_method performs a nil-check. (NilCheck)'
].join("\n"))
result.stub(:stderr).and_return('')
context 'in old format' do
before do
result.stub(:stdout).and_return([
'file1.rb -- 1 warning:',
'file1.rb:1: MyClass#my_method performs a nil-check. (NilCheck)'
].join("\n"))
result.stub(:stderr).and_return('')
end

it { should fail_hook }
it 'parses the right file' do
subject.run.map(&:file).should == ['file1.rb']
end
end

it { should fail_hook }
context 'in new format' do
before do
result.stub(:stdout).and_return([
'file1.rb -- 1 warning:',
' file1.rb:1: MyClass#my_method performs a nil-check. (NilCheck)'
].join("\n"))
result.stub(:stderr).and_return('')
end

it { should fail_hook }
it 'parses the right file' do
subject.run.map(&:file).should == ['file1.rb']
end
end
end
end
end