Skip to content

Conversation

@jawshooah
Copy link
Collaborator

Fixes #219

@lencioni
Copy link
Collaborator

lencioni commented Jun 3, 2015

👍 want to add a line to the changelog while you are at it?

@jawshooah
Copy link
Collaborator Author

Done!

@sds sds merged commit 6be3b8e into sds:master Jun 3, 2015
@sds sds added the bug label Jun 3, 2015
@lencioni
Copy link
Collaborator

lencioni commented Jun 3, 2015

Thanks for the code @jawshooah!

@sds
Copy link
Owner

sds commented Jun 3, 2015

Thanks for the pull request, @jawshooah.

On deeper thought, I think I merged this too early. This doesn't solve the underlying problem, which is that HookContext::PreCommit#modified_files returns non-existent files. We should probably hoist a fix close to the source of the problem to properly fix this. I'm happy to look into that later.

@jawshooah jawshooah deleted the amend-rename-fix branch June 3, 2015 21:34
@sds
Copy link
Owner

sds commented Jun 11, 2015

Closing the loop on this to say I implemented a more thorough fix with a test in b450815.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants