Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,14 @@ PreCommit:
- 'db/schema.rb'
- 'db/structure.sql'

Recess:
enabled: false
description: 'Analyzing with recess'
required_executable: 'recess'
install_command: 'npm install -g recess'
flags: ['--format=compact', '--stripColors']
include: '**/*.css'

Reek:
enabled: false
description: 'Analyzing with Reek'
Expand Down
18 changes: 18 additions & 0 deletions lib/overcommit/hook/pre_commit/recess.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
module Overcommit::Hook::PreCommit
# Runs `recess` against any modified CSS files.
#
# @see https://twitter.github.io/recess/
class Recess < Base
MESSAGE_REGEX = /^(?<file>(?:\w:)?[^:]+):(?<line>\d+):.+$/

def run
result = execute(command, args: applicable_files)

raw_messages = result.stdout.split("\n").grep(MESSAGE_REGEX)

# example message:
# path/to/file.css:1:Error message
extract_messages(raw_messages, MESSAGE_REGEX)
end
end
end
43 changes: 43 additions & 0 deletions spec/overcommit/hook/pre_commit/recess_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
require 'spec_helper'

describe Overcommit::Hook::PreCommit::Recess do
let(:config) { Overcommit::ConfigurationLoader.default_configuration }
let(:context) { double('context') }
subject { described_class.new(config, context) }

let(:result) { double('result') }

before do
subject.stub(:applicable_files).and_return(%w[file1.css file2.css])
subject.stub(:execute).and_return(result)
end

context 'when recess exits successfully' do
let(:result) { double('result') }

before do
result.stub(:success?).and_return(true)
end

context 'with no errors' do
before do
result.stub(:stdout).and_return(normalize_indent(<<-OUT))
FILE: file1.css
STATUS: Perfect!
OUT
end

it { should pass }
end

context 'and it reports an error' do
before do
result.stub(:stdout).and_return(normalize_indent(<<-OUT))
file1.css:1:Element selectors should not be overqualified
OUT
end

it { should fail_hook }
end
end
end