Skip to content

Conversation

@jawshooah
Copy link
Collaborator

This will help in debugging #271.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Printing debug messages breaks the output of the hook with the way we currently output OK/FAIL at the end of the hook's run, so I'd be hesitant to commit this in even if it only appeared with OVERCOMMIT_DEBUG=1.

This has come up a few times, so it seems like we need to expose a call that allows a hook to aggregate log messages which are printed in addition to its regular output when debugging is enabled (but printed at the end of the hook run).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We'd need to gate the run in a begin...ensure block so that log messages are printed even if the hook run throws an exception.

@sds sds added the invalid label Oct 3, 2015
@sds
Copy link
Owner

sds commented Oct 3, 2015

Going to close this since the original issue seems quiet, and I'd rather not commit something to master to help what appears to be a user hitting an edge case of some sort, given @jawshooah's difficulty in reproducing the issue.

@sds sds closed this Oct 3, 2015
@jawshooah jawshooah deleted the protected_branches/log_pushed_refs branch January 2, 2016 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants