Skip to content

Conversation

@hasghari
Copy link

This is a fix for Issue #480

When pushing tags, the pushed ref will look something like this:

refs/tags/release-0.1 e0250d9551467b32e2292ff163961b3af0f8ac67 refs/tags/release-0.1 0000000000000000000000000000000000000000

This does not match the regular expression pattern of refs/heads, hence the failure.

@sds sds added the bug label Mar 23, 2017
@sds sds merged commit 336c495 into sds:master Mar 23, 2017
@sds
Copy link
Owner

sds commented Mar 23, 2017

Thanks for the PR, @hasghari!

Would be nice if we could protect against pushing arbitrary refs, but feels like this solution satisfies the common case.

The failure on Windows seems to be spurious (I've retried that build multiple times at it seems to always fail on a different version of Ruby, so the lack of consistency tells me the failure is not caused by your changes.

@hasghari hasghari deleted the pre-push-tags branch March 24, 2017 04:42
@hasghari
Copy link
Author

Thanks for the merge @sds. Can we get a patch release for this fix?

@sds
Copy link
Owner

sds commented Mar 27, 2017

Looking to release a new version soon, @hasghari. Just waiting for #479 to be wrapped up. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants