Skip to content

Run golint for each file that has changed #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Run golint for each file that has changed #530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
999722b
Run `golint` for each file that has changed
varunpatro Dec 3, 2017
c0aa43d
Remove trailing space and redundant variables
varunpatro Dec 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/overcommit/hook/pre_commit/go_lint.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@ module Overcommit::Hook::PreCommit
# @see https://github.com/golang/lint
class GoLint < Base
def run
result = execute(command, args: applicable_files)
output = result.stdout + result.stderr
output = ''

# golint doesn't accept multiple file arguments if
# they belong to different packages
applicable_files.each do |gofile|
result = execute(command, args: Array(gofile))
output += result.stdout + result.stderr
end

# Unfortunately the exit code is always 0
return :pass if output.empty?

Expand Down