Skip to content

Improve performance of Gemfile.lock ignore check for BundleAudit hook #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Improve performance of Gemfile.lock ignore check for BundleAudit hook #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02791d3
Improve performance of Gemfile.lock ignore check
jlogsdon Dec 11, 2017
2461583
Split Gemfile.lock check over multiple lines
jlogsdon Dec 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/overcommit/hook/pre_commit/bundle_audit.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ class BundleAudit < Base

def run
# Ignore if Gemfile.lock is not tracked by git
ignored_files = execute(%w[git ls-files -o -i --exclude-standard]).stdout.split("\n")
ignored_files = execute(%W[git ls-files -o -i --exclude-standard -- #{LOCK_FILE}]).
stdout.split("\n")
return :pass if ignored_files.include?(LOCK_FILE)

result = execute(command)
Expand Down
2 changes: 1 addition & 1 deletion spec/overcommit/hook/pre_commit/bundle_audit_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
end

before do
subject.stub(:execute).with(%w[git ls-files -o -i --exclude-standard]).
subject.stub(:execute).with(%w[git ls-files -o -i --exclude-standard -- Gemfile.lock]).
and_return(double(stdout: ''))
subject.stub(:execute).with(%w[bundle-audit]).and_return(result)
end
Expand Down