Extract Install Hooks Common Code #544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taufek
force-pushed
the
tj-refactor-shared-install-hook
branch
from
22ac727 to
7c8ad33
Compare
While working on adding `ComposerInstall` hook in d9ac62e, I noticed all the Install hooks mostly look the same with minor difference. Extracted the common code to `SimpleInstall` module making things DRYer.
taufek
force-pushed
the
tj-refactor-shared-install-hook
branch
from
7c8ad33 to
e0a31b3
Compare
Owner
|
Thanks for looking for opportunities to DRY up the code, @taufek. It's really appreciated. In this case, I don't think the benefit is worthwhile. These implementations are already quite simple —a few lines each—and DRYing them up actually results in more lines of code overall. If I'm missing something with what you're trying to achieve, let me know, but I'm going to close this as YAGNI for now. Thanks! |
Contributor
Author
|
Understood. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on adding
ComposerInstallhook in d9ac62e,I noticed all the Install hooks mostly look the same with minor difference.
Extracted the common code to
SimpleInstallmodule making things DRYer.