Modified Lines in File for PrePush Context #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sds
reviewed
Feb 5, 2018
| @modified_lines[file] | ||
| end | ||
|
|
||
| def refs |
Owner
There was a problem hiding this comment.
Let's use the nomenclature in the Git documentation and call this ref_range. I'm concerned that in this context refs is a bit too vague for folks looking at this code for the first time.
| Overcommit::GitRepo.extract_modified_lines(file, refs: refs) | ||
| end | ||
|
|
||
| @modified_lines[file] |
Owner
There was a problem hiding this comment.
You can shorten this method implementation to:
@modified_lines ||= {}
@modified_lines[file] ||= Overcommit::GitRepo.extract_modified_lines(...)
Continuation from sds#536 where it added `modified_files` for `PrePush` context. This is to add `modified_lines_in_file` for `PrePush` context.
taufek
force-pushed
the
tj-pre-push-mod-file-lines
branch
from
812bbb8 to
664ff82
Compare
Contributor
Author
|
@sds . Thanks for the feedback. This is ready for re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #536 where it added
modified_filesforPrePushcontext.This is to add
modified_lines_in_fileforPrePushcontext.