Add Ruby 2.5.0 to build matrix #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mattbrictson
force-pushed
the
travis-ruby-2.5.0
branch
from
af224d4 to
c2050c4
Compare
Contributor
Author
|
... and it succeed in Travis anyway. I guess it must be a macOS-specific issue. In any case, it is still probably worthwhile to add 2.5.0 to the build matrix. Rebased. |
Owner
|
Thanks for the PR, @mattbrictson. Very strange that you couldn't reproduce on Travis, but having 2.5 in the build matrix is a good thing regardless, so thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #554 was specific to Ruby 2.5.0, which is a good reminder that 2.5.0 should be included in the Travis matrix.