Terraform support #616
Merged
Terraform support #616
+69
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msurovcak
force-pushed
the
terraform_support
branch
2 times, most recently
from
9397eda to
a5cd495
Compare
sds
reviewed
Feb 7, 2019
Owner
sds
left a comment
sds
left a comment
There was a problem hiding this comment.
Overall looks great, @msurovcak! Thanks for the pull request.
Happy to merge once comments are addressed. Thanks!
| # frozen_string_literal: true | ||
|
|
||
| module Overcommit::Hook::PreCommit | ||
| # Runs 'terraform -fmt' against any modified *.tf files. |
config/default.yml
Outdated
| install_command: 'brew install swiftlint' | ||
| include: '**/*.swift' | ||
|
|
||
| Terraform: |
Owner
There was a problem hiding this comment.
I would say we should call this TerraformFormat, as that is ultimately what it is checking. While I know Terraform is a pretty ubiquitous tool at this point, I think for some users just seeing "Terraform" doesn't necessarily hint at what it is doing.
Simply check terraform fmt. Fixes sds#567
msurovcak
force-pushed
the
terraform_support
branch
from
a5cd495 to
b50eaf7
Compare
Contributor
Author
|
Thanks for the review @sds, addresses both comments as they make perfect sense + updated error message to be more human language, not just filename. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply check
terraform fmtto ensure Terraform code is ok.Fixes #567