-
Notifications
You must be signed in to change notification settings - Fork 280
add cookstyle support to fix #617 #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, @indygwyn. Just needs the default configuration updated so the tests pass.
config/default.yml
Outdated
| include: '**/*.coffee' | ||
|
|
||
| Credo: | ||
| CookStyle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation looks slightly off here, which may explain why the tests failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it ironic my updating of a style linter enforcer gets caught by a style linting problem
|
Not sure how I can fix that check in AppVeyor that's failing |
|
I would ignore the symlink error in AppVeyor, @indygwyn. I missed this in my last review, but can you add an accompanying test? You can see an example from another recent pull request here: https://github.com/brigade/overcommit/pull/616/files#diff-2da0444d3bba168fda49f24b7abe274d |
|
@sds Okay, I tried writing my own rspec's but I kept getting an error, so I reverted to just a copy of rubocop's which should work fine since cookstyle is just a wrapper around rubocop, hopefully this works for ya. |
|
Thanks @indygwyn! |
No description provided.