Skip to content

Conversation

@indygwyn
Copy link
Contributor

No description provided.

Copy link
Owner

@sds sds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, @indygwyn. Just needs the default configuration updated so the tests pass.

include: '**/*.coffee'

Credo:
CookStyle:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks slightly off here, which may explain why the tests failed.

Copy link
Contributor Author

@indygwyn indygwyn Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it ironic my updating of a style linter enforcer gets caught by a style linting problem

@indygwyn
Copy link
Contributor Author

Not sure how I can fix that check in AppVeyor that's failing
Check for broken symlinks............................[BrokenSymlinks] FAILED ...um

@sds
Copy link
Owner

sds commented Feb 23, 2019

I would ignore the symlink error in AppVeyor, @indygwyn.

I missed this in my last review, but can you add an accompanying test? You can see an example from another recent pull request here: https://github.com/brigade/overcommit/pull/616/files#diff-2da0444d3bba168fda49f24b7abe274d

@indygwyn
Copy link
Contributor Author

@sds Okay, I tried writing my own rspec's but I kept getting an error, so I reverted to just a copy of rubocop's which should work fine since cookstyle is just a wrapper around rubocop, hopefully this works for ya.

@sds sds merged commit 7b3e850 into sds:master Feb 26, 2019
@sds
Copy link
Owner

sds commented Feb 26, 2019

Thanks @indygwyn!

@indygwyn indygwyn deleted the cookstylesupport branch February 26, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants