Correct extract line number output in Stylelint hook #641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MESSAGE_REGEX for stylelint does not appropriately extract
line numbers >= 10. This can cause the hook to incorrectly report
errors on modified lines as being for lines that are not modified.
This commit changes the regex to correctly handle multiple digits in
line numbers.
Reproduction Steps
.overcommit.ymlin the repositorystylelintand create a.stylelintrc.jsonfile in the repository:failing_file.scssin the repository with the following content:failing_file.scssto be the following:git commit -a. This should fail with an error on the modified line. Instead, it passes with a warning on lines you did not modify:After this change, the check fails with an error as expected.