Skip to content

Add check for Ginkgo Focused tests #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2019
Merged

Add check for Ginkgo Focused tests #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a0298a
Add GinkgoFocus
a-b Aug 10, 2019
3473f70
Update copy
a-b Aug 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions config/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,13 @@ PreCommit:
quiet: true
branch_patterns: ['master']

GinkgoFocus:
enabled: false
description: 'Check for "focused" tests'
required_executable: 'grep'
flags: ['-IEHnw']
keywords: ['FContext','FDescribe','FIt','FMeasure','FSpecify','FWhen']

GoLint:
enabled: false
description: 'Analyze with golint'
Expand Down
23 changes: 23 additions & 0 deletions lib/overcommit/hook/pre_commit/ginkgo_focus.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# frozen_string_literal: true

module Overcommit::Hook::PreCommit
# Check for "focused" tests
class GinkgoFocus < Base
def run
keywords = config['keywords']
result = execute(command, args: [keywords.join('|')] + applicable_files)

extract_messages(
result.stdout.split("\n"),
/^(?<file>(?:\w:)?[^:]+):(?<line>\d+)/,
lambda { |_type| :warning }
)
end

def applicable_test_files
applicable_files.select do |f|
f if f =~ /_test\.go/
end
end
end
end