Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1253,6 +1253,12 @@ PrePush:
required_executable: 'git-lfs'
install_command: 'brew install git-lfs'

GoTest:
enabled: false
description: 'Run go test suite'
required_executable: 'go'
command: ['go', 'test', './...']

Minitest:
enabled: false
description: 'Run Minitest test suite'
Expand Down
14 changes: 14 additions & 0 deletions lib/overcommit/hook/pre_push/go_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# frozen_string_literal: true

module Overcommit::Hook::PrePush
# Runs `go test ./...` command on prepush
class GoTest < Base
def run
result = execute(command)
return :pass if result.success?

output = result.stdout + result.stderr
[:fail, output]
end
end
end
66 changes: 66 additions & 0 deletions spec/overcommit/hook/pre_push/go_test_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
# frozen_string_literal: true

require 'spec_helper'

describe Overcommit::Hook::PrePush::GoTest do
let(:config) { Overcommit::ConfigurationLoader.default_configuration }
let(:context) { double('context') }
subject { described_class.new(config, context) }

context 'when go test exits successfully' do
let(:result) { double('result') }

before do
result.stub(success?: true, stderr: '', stdout: '')
subject.stub(:execute).and_return(result)
end

it 'passes' do
expect(subject).to pass
end
end

context 'when go test exits unsucessfully' do
let(:result) { double('result') }

before do
result.stub(:success?).and_return(false)
subject.stub(:execute).and_return(result)
end

context 'when go test returns an error' do
let(:error_message) { "--- FAIL: Test1 (0.00s)\nFAIL" }

before do
result.stub(:stdout).and_return(error_message)
result.stub(:stderr).and_return('')
end

it 'fails' do
expect(subject).to fail_hook
end

it 'returns valid message' do
message = subject.run.last
expect(message).to eq error_message
end
end

context 'when a generic error message is written to stderr' do
let(:error_message) { 'go: command not found' }
before do
result.stub(:stdout).and_return('')
result.stub(:stderr).and_return(error_message)
end

it 'fails' do
expect(subject).to fail_hook
end

it 'returns valid message' do
message = subject.run.last
expect(message).to eq error_message
end
end
end
end