[PrePush::ProtectedBranches] Implement setting destructive_only per branch #692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrePush::ProtectedBranchessupports adestructive_onlysetting. However, this setting is globally valid for all protected branches. It makes sense to set this setting on a per branch basis. This PR implements the following syntax for the configuration ofProtectedBranches.In case it is not set on a branch it will fall back to the global setting. Additionally it will use the setting of the first matching branch.
Example:
In this case, a push to
releases/v1would be forbidden becausereleases/*would match which uses the global setting fordestructive_only. The solution in this case would be to flip the order of the branch definitions.Credit for this idea goes to @davidstosik 🎉