Skip to content

Fix YamlLint hook. #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2020
+6 −2
Merged

Fix YamlLint hook. #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Overcommit Changelog

## master

* Fix `YamlLint` pre-commit hook

## 0.53.0

* Improve performance in `PhpCs` pre-commit hook
Expand Down
2 changes: 1 addition & 1 deletion config/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,7 @@ PreCommit:
enabled: false
description: 'Analyze with YAMLlint'
required_executable: 'yamllint'
flags: ['--format=parsable']
flags: ['--format=parsable', '--strict']
install_command: 'pip install yamllint'
include:
- '**/*.yaml'
Expand Down
2 changes: 1 addition & 1 deletion spec/overcommit/hook/pre_commit/yaml_lint_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
end

before do
subject.stub(:execute).with(%w[yamllint --format=parsable], args: applicable_files).
subject.stub(:execute).with(%w[yamllint --format=parsable --strict], args: applicable_files).
and_return(result)
end

Expand Down