Skip to content

Conversation

@Quintasan
Copy link
Contributor

@sds This went under the radar since modified_files is delegated via Overcommit::Hook::Base.

Now that I tried writing a custom hook I noticed modified_lines_in_file is not available inside Overcommit::Hook::CommitMsg::Base. I decided to expose only the method I need but I think it's worth thinking about if we want to delegate all methods that come from included modules by default

This went under the radar since `modified_files` is delegated via
`Overcommit::Hook::Base`.
@Quintasan
Copy link
Contributor Author

@sds ding

@sds sds merged commit ed0d0ec into sds:master Oct 3, 2020
@sds
Copy link
Owner

sds commented Oct 3, 2020

Thanks for the ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants