-
Notifications
You must be signed in to change notification settings - Fork 280
Support pre-commit.d folder #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are some tool that uses the pre-commit hook as well. It is possible to have multiple hooks in same time with folder `.git/hooks/pre-commit.d`
|
Thanks for the PR, @miry. I'm not clear on the value of mixing different hook management systems in the same repository. Can you elaborate on why a development team would be using two systems? |
|
@sds In some companies there are some internal tools exists for development environment. The internal tool required to have pre-commit hook, in same time it does not provide the same functionality as overcommit and focused only on specific commands. As workaround I need manually to update the overcommit hook. |
|
It's not clear why the specific nuances of some companies requires Overcommit to accommodate? It seems like a company should standardize on a single workflow? Imposing multiple workflows on the tools the company uses doesn't seem like the right course of action. With that said—would be supportive of a pull request that allows users to customize the directories that Overcommit reads hooks from. That way you could specify any directory (not just |
|
The code that I introduce support any folder: Before to update all <hook_type> templates, I wanted to be sure that it is valid idea.
This is right, but it is not easy to do in big companies. In same time the tool support custom hooks as I had implemented. Some use case when I would like to use overcommit and other hook:
|
|
It's still not entirely clear how this adds support for any directory. It adds support for directories of the form Could you not just register each hook as described in the documentation? |
I could not. I put overcommit to I think it is only my problem, so will keep the fork version. |
|
FYI: Added support of installation hooks to directories in the fork: miry#1 |
There are some tool that uses the pre-commit hook as well. It is possible to have multiple hooks in same time with folder
.git/hooks/pre-commit.d