Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
Allowing some resources to be missing a routePath is actually not the correct approach. |
Member
Author
|
I've updated the PR to extend the blueprint with |
razor-x
force-pushed
the
routeless-paths
branch
from
9f69cb4 to
2469ccb
Compare
razor-x
commented
Feb 27, 2025
andrii-balitskyi
pushed a commit
that referenced
this pull request
Feb 28, 2025
* Move Seam extensions into seam.js * feat: Allow null routePath for some resources * ci: Format code * Move pagination to blueprint * Add pagination to fixture * ci: Generate code * ci: Format code * Make pagination nullable * Add createPagination * ci: Generate code * Implement createPagination * Implement hasPagination * Update src/lib/blueprint.ts * Use responseKey over paginationResponseKey * ci: Generate code * Use paginationResponseKey via openapi.components.schemas * Update fixture --------- Co-authored-by: Seam Bot <seambot@getseam.com>
andrii-balitskyi
added a commit
that referenced
this pull request
Mar 5, 2025
…uctures (#163) * Enhance array properties with item type metadata and nested structures * ci: Generate code * Fix lint * Properly define list types and adjust the code * Remove jsonType * ci: Generate code * feat: Add pagination support (#162) * Move Seam extensions into seam.js * feat: Allow null routePath for some resources * ci: Format code * Move pagination to blueprint * Add pagination to fixture * ci: Generate code * ci: Format code * Make pagination nullable * Add createPagination * ci: Generate code * Implement createPagination * Implement hasPagination * Update src/lib/blueprint.ts * Use responseKey over paginationResponseKey * ci: Generate code * Use paginationResponseKey via openapi.components.schemas * Update fixture --------- Co-authored-by: Seam Bot <seambot@getseam.com> * 0.36.0 * fix: Merge all schemas with the same action_type in action attempts (#164) Co-authored-by: Seam Bot <seambot@getseam.com> * 0.36.1 * Update src/lib/blueprint.ts Co-authored-by: Evan Sosenko <evan@getseam.com> * Fix types --------- Co-authored-by: Seam Bot <seambot@getseam.com> Co-authored-by: Evan Sosenko <evan@getseam.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing some resources to be missing a routePath is actually not the correct approach.
I will update this PR to make pagination a proper idea in blueprint, e.g., the Pagination should be it's own thing and endpoints should include if they support pagination.