Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
razor-x
reviewed
Apr 17, 2025
| undocumentedMessage: string | ||
| isDraft: boolean | ||
| draftMessage: string | ||
| default?: any |
Member
There was a problem hiding this comment.
Per you comment, this can be moved off of the base type and defined per specific type to match the parameter type.
Suggested change
| default?: any |
Contributor
Author
mikewuu
changed the title
razor-x
reviewed
Apr 17, 2025
Member
razor-x
left a comment
razor-x
left a comment
There was a problem hiding this comment.
Since null is a valid default value for non-list parameters, let's add hasDefault to the BaseParameter
Co-authored-by: Evan Sosenko <evan@getseam.com>
Co-authored-by: Evan Sosenko <evan@getseam.com>
Co-authored-by: Evan Sosenko <evan@getseam.com>
Co-authored-by: Evan Sosenko <evan@getseam.com>
Co-authored-by: Evan Sosenko <evan@getseam.com>
Co-authored-by: Evan Sosenko <evan@getseam.com>
Co-authored-by: Evan Sosenko <evan@getseam.com>
razor-x
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for https://linear.app/seam/issue/CX-284/show-default-values-for-all-parameters-in-seam-connect, this PR parses out the default from the openapi schema.
Notable things
Went with
anytype here for the default. Checked the openapi type, and it that's what it was there, so I figured it might be ok here too. Maybe we can update the ts type with a generic to say thedefaultshould be the same time as the value?