Skip to content

fix: Fix action attempt properties processing#181

Merged
andrii-balitskyi merged 2 commits intomainfrom
fix-action-attempt-result-and-error-def
May 6, 2025
Merged

fix: Fix action attempt properties processing#181
andrii-balitskyi merged 2 commits intomainfrom
fix-action-attempt-result-and-error-def

Conversation

@andrii-balitskyi
Copy link
Copy Markdown
Contributor

@andrii-balitskyi andrii-balitskyi commented May 2, 2025

Action attempt logic assumed that nullable prop schemas only have the nullable: true property, but they can also include a description property. This false assumption resulted in incorrect property schemas being defined on action attempt resources.

WRT CX-297.

@andrii-balitskyi andrii-balitskyi requested a review from a team as a code owner May 2, 2025 13:40
@vercel
Copy link
Copy Markdown

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blueprint ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:41pm

@andrii-balitskyi andrii-balitskyi changed the title fix: Correctly define 'result' and 'error' props on action attempt fix: Fix action attempt properties processing May 2, 2025
@andrii-balitskyi andrii-balitskyi requested a review from razor-x May 2, 2025 13:44
@andrii-balitskyi andrii-balitskyi merged commit 5f1ef84 into main May 6, 2025
22 checks passed
@andrii-balitskyi andrii-balitskyi deleted the fix-action-attempt-result-and-error-def branch May 6, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants