Skip to content

fix: avoid style injection #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: avoid style injection #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
923fa90
fix: avoid style injection
mikewuu May 28, 2023
7434615
Remove unused disableCssInjection prop
mikewuu May 28, 2023
e6efef0
Fix missing index.css import
mikewuu May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ const preview: Preview = {
publishableKey={publishableKey}
userIdentifierKey={userIdentifierKey}
endpoint={seamEndpoint}
disableCssInjection
disableFontInjection
>
<Story />
Expand Down
1 change: 0 additions & 1 deletion examples/basic/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export const App = (): JSX.Element => {
endpoint={import.meta.env.SEAM_ENDPOINT}
publishableKey={import.meta.env.SEAM_PUBLISHABLE_KEY}
userIdentifierKey={import.meta.env.SEAM_USER_IDENTIFIER_KEY}
disableCssInjection
>
<main>
<h1>Seam Components</h1>
Expand Down
12 changes: 6 additions & 6 deletions src/lib/SeamProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
'use client'
import '@seamapi/react/index.css'

import { QueryClient, QueryClientProvider } from '@tanstack/react-query'
import {
Expand All @@ -10,7 +11,6 @@ import {
import type { Seam, SeamClientOptions } from 'seamapi'

import { useSeamFont } from './seam/use-seam-font.js'
import { useSeamStyles } from './seam/use-seam-styles.js'

declare global {
// eslint-disable-next-line no-var
Expand Down Expand Up @@ -46,18 +46,17 @@ interface SeamProviderPropsWithClientSessionToken {
}

interface SeamProviderBaseProps {
disableCssInjection?: boolean | undefined
disableFontInjection?: boolean | undefined
useUnminifiedCss?: boolean | undefined
disableStyles?: boolean | undefined
}

type AllowedSeamClientOptions = Pick<SeamClientOptions, 'endpoint'>

export function SeamProvider({
children,
disableCssInjection = false,
disableFontInjection = false,
useUnminifiedCss = false,
disableStyles = false,
...props
}: PropsWithChildren<SeamProviderProps>): JSX.Element {
const { Provider } = seamContext
Expand All @@ -83,11 +82,12 @@ export function SeamProvider({
)
}

useSeamStyles({ disabled: disableCssInjection, unminified: useUnminifiedCss })
useSeamFont({ disabled: disableFontInjection })

const className = disableStyles ? '' : 'seam-components'

return (
<div className='seam-components'>
<div className={className}>
<QueryClientProvider client={queryClientRef.current}>
<Provider value={{ ...contextRef.current }}>{children}</Provider>
</QueryClientProvider>
Expand Down
31 changes: 0 additions & 31 deletions src/lib/seam/use-seam-styles.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/fixtures/react.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ function Providers({ children }: PropsWithChildren): JSX.Element {
endpoint={globalThis.JEST_SEAM_ENDPOINT}
publishableKey={globalThis.JEST_SEAM_PUBLISHABLE_KEY_1}
userIdentifierKey='some_user'
disableCssInjection
disableFontInjection
>
{children}
Expand Down