This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Properly address #125 #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reworks the python rules in .vscodeignore to be compatible with vsce 1.92.0 and above.
Owner
|
@tjquillan Thanks for the PR. It is always welcome to make some additional cleanups! I find that most of the bundled files is unnecessary, such as |
node_modules and .github were also added despite the fact that they seem to already be ignored for some reason as adding them will prevent them being included if vsce behavior changes in the future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should properly address issue #125 rather than simply downgrading vsce.
Side notes:
**is not needed at the end of things likesrc/**as the whole directory is ignored anyway..huskyis included in the final package. Is this intentional?