Skip to content

fix: close selector via click outside #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

fix: close selector via click outside #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/ClickOutside/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,25 +62,27 @@ class ClickOutside extends React.Component {
document.removeEventListener('mousedown', this.handleDocumentClick);
}

setClickedInsideStatus = (status) => {
this.isClickedInside = status || false;
}

handleDocumentClick = (e) => {
if (this.isClickedInside) {
this.isClickedInside = false;
this.setClickedInsideStatus(false);
return;
}

this.props.onClickOutside(e);
};

handleMouseDown = () => {
this.isClickedInside = true;
this.setClickedInsideStatus(true);
};

render() {
return React.cloneElement(
React.Children.only(this.props.children), {
onMouseDownCapture: this.handleMouseDown
}
);
return React.cloneElement(React.Children.only(this.props.children), {
onMouseDownCapture: this.handleMouseDown
});
}
}

Expand Down
6 changes: 5 additions & 1 deletion src/SelectOptionGroup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ class SelectOptionGroup extends Component {
if (isInModal) {
e.stopPropagation();
e.nativeEvent.stopImmediatePropagation();

// ClickOutside set isClickedInside to true via mouse down capture first
// Set isClickedInside to false after mouse down
this.clickOutsideRef && this.clickOutsideRef.setClickedInsideStatus(false);
}
};

Expand Down Expand Up @@ -177,7 +181,7 @@ class SelectOptionGroup extends Component {
};
}
return (
<ClickOutside onClickOutside={this.props.onClickOutside}>
<ClickOutside ref={ref => this.clickOutsideRef = ref} onClickOutside={this.props.onClickOutside}>
<div
className={classnames('option-group', className ? 'option-group-' + className : '', {
'pt-0': isShowSelected,
Expand Down