Simplify Xml/File #1120
Merged
Simplify Xml/File #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
============================================
- Coverage 88.63% 88.62% -0.02%
+ Complexity 1398 1397 -1
============================================
Files 105 105
Lines 4795 4790 -5
============================================
- Hits 4250 4245 -5
Misses 545 545 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
staabm
commented
Nov 20, 2025
|
|
||
| public function lineCoverage(string $line): Coverage | ||
| { | ||
| $coverage = $this->contextNode->getElementsByTagNameNS( |
Contributor
Author
There was a problem hiding this comment.
this removes one DOM call per line of code beeing analyzed. I expect this to improve performance.. will measure it
Contributor
Author
There was a problem hiding this comment.
its 1-2 seconds faster. previously 21-22 seconds now ~19-20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see description in each commit
overall goal: remove unnecessary DOM operations