This repository was archived by the owner on Feb 20, 2023. It is now read-only.
Improve ReturnValueMap #285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@sebastianbergmann any chance you would accept such a PR? It resolves the issues listed in #318 (or at least provides workaround for them). I will rebase and apply any changes you request |
|
Dear @sebastianbergmann can this PR be merged please? Problem with mocking functions which have objects in parameters is very very annoying. |
Author
|
@dpauli I have rebased my fork on the current master and published as separate package. Feel free to use it and I'll take care of rebasing if needed |
Owner
|
Thank you for your contribution. I am sorry that I did not get around to review/merge this sooner. Please send a new pull request against current |
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that ReturnValueMap lacks is flexibility regarding the arguments the method was invoked with. It works only with exact match. As a side effect, if you have floats as arguments, it may fail. As a solution, I've added support for Framework_Constraint objects.
Another one is that the return value is just a simple value. So I've added the option to use Framework_Stub objects, such as ReturnCallback