Allow use of Constraints in ReturnValueMap #4000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One thing that ReturnValueMap lacked was flexibility regarding the arguments the method was invoked with. It works only with exact match As a side effect, if you have floats as arguments, it may fail. As a solution, support has been added for Framework/Constraint objects.
Codecov Report
@@ Coverage Diff @@
## master #4000 +/- ##
============================================
- Coverage 85.5% 85.44% -0.07%
- Complexity 3849 3856 +7
============================================
Files 156 156
Lines 9720 9733 +13
============================================
+ Hits 8311 8316 +5
- Misses 1409 1417 +8
Continue to review full report at Codecov.
|
sebastianbergmann
added
feature/test-doubles
Owner
|
This branch has conflicts that must be resolved. |
sebastianbergmann
force-pushed
the
master
branch
from
5d5ef3e to
4303365
Compare
|
@mstyles Hi! This is very helpful pr, check it out please |
tweet9ra
approved these changes
Oct 11, 2021
sebastianbergmann
force-pushed
the
master
branch
from
6aa2fbc to
078538a
Compare
13 tasks
sebastianbergmann
force-pushed
the
main
branch
3 times, most recently
from
08dc555 to
63591f3
Compare
Owner
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that ReturnValueMap lacked was flexibility regarding the
arguments the method was invoked with. It works only with exact match As
a side effect, if you have floats as arguments, it may fail. As a
solution, support has been added for Framework/Constraint objects.
#3999