properly impl add/subtract along with some since&untill #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianjacmatt
commented
Nov 9, 2025
| ) | ||
| .unbind()? | ||
| .bind(gc.nogc()); | ||
| // 9. If microseconds is not undefined, set result.[[Microseconds]] to ? ToIntegerIfIntegral(microseconds). |
Owner
Author
There was a problem hiding this comment.
ToIntegerIfIntegral on microsecounds, returns a Number, however microsecounds as per temporal_rs::partial::PartialDuration should be a i128.
We have try_into_i128 from BigInt,could potentially use this?
sebastianjacmatt
commented
Nov 9, 2025
| } | ||
|
|
||
| /// Convert a Number to BigInt | ||
| pub fn to_big_int(self, agent: &mut Agent) -> BigInt<'a> { |
Owner
Author
There was a problem hiding this comment.
This would mean that we need to create the Number to BigInt conversion function to_big_int for Number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a lot but mainly on implementation of add and subtract, although it also adds some stuff for since and untill