v3.0-actions #3
Merged
v3.0-actions #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build-cmd.py used to run an internal 'pip install' to pull in Python package dependencies. Because of the persistent side effect beyond the current build, it aborted unless the build was running in a virtualenv, presumed to be transient for the current build. Since every GitHub workflow is run in a transient environment, this check is no longer needed. Moreover, since the build.yaml file can set up the environment, we simply add a 'pip install' step before the action-autobuild step. Remove the related code from build-cmd.py. Don't run on 64-bit Windows: we explicitly want only a 32-bit Windows build. Defend against eventual removal of the deprecated cgitb package. Now that there's only one call of the build-cmd.py run() convenience function, usually unused, the convenience is no longer required.
Specify `python-architecture` as appropriate in build.yaml. This should fix win32 builds, which require a python interpreter of matching architecture.
Specify `python-architecture` as appropriate in build.yaml. This should fix win32 builds, which require a python interpreter of matching architecture.
Workaround for zst compression failing on 32-bit
Specify `python-architecture` as appropriate in build.yaml. This should fix win32 builds, which require a python interpreter of matching architecture.
It seems that when directed to produce a TarFile(mode='w:bz2'), the Python tarfile module running on GitHub produces a bzip2 compression that's valid (can be decompressed with bunzip2) but is unknown to Python 3.10's tarfile module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.