#3997 Crash in a gltf asset enabled region

[akleshchev]

No description provided.

[Hecklezz]

Related to this same crash, on line 1672 in llvertexbuffer.cpp, LLGLSLShader::sCurBoundShaderPtr is a nullptr so this assert fails, and then line 1674 will throw a null reference exception.

[aiaustin]

Question, should there not be something server side to protect against such a crash as the viewers Collada Mesh Uploader does allow the example mesh to be uploaded, save and rezzed without indicating any error at all.

[Hecklezz]

Related to this same crash, on line 1672 in llvertexbuffer.cpp, LLGLSLShader::sCurBoundShaderPtr is a nullptr so this assert fails, and then line 1674 will throw a null reference exception.

Fixing this then causes a nullptr exception also on line 761 in gltfscenemanager.cpp since it is accessing LLGLSLShader::sCurBoundShaderPtr again which is nullptr as described above.

[akleshchev]

should there not be something server side

1. Server side is not responsible for rendering
2. This crash happens because viewer uses an experimental feature on this region. It's viewer's fault for not initializing variables properly (I'm doing a hotfix here because fixing it properly is going to take too long and feature is currently frozen).

LLGLSLShader::sCurBoundShaderPtr

Thank you, will check that.

[Hecklezz]

The latest hotfix works and the viewer is no longer crashing due to this specific bug.