#4184 clearAndDeparentModels crash #4295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-productengine
approved these changes
Jun 26, 2025
akleshchev
force-pushed
the
andreyk/viewer_4184
branch
2 times, most recently
from
7ceb3a7 to
b0eba2b
Compare
marchcat
approved these changes
Jun 26, 2025
akleshchev
force-pushed
the
andreyk/viewer_4184
branch
from
b0eba2b to
f409931
Compare
To resolve dual ownership switched children to LLPointer
akleshchev
force-pushed
the
andreyk/viewer_4184
branch
from
f409931 to
a4e89b9
Compare
|
Added a bunch of macOS build fixes, it was complaining about overrides. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve dual ownership switched children to LLPointer.
High risk! I expect it to cause issues and crashes early on, but no apparent way around it.