Media first click interact friend check fix #4428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Jul 25, 2025
akleshchev
reviewed
Jul 26, 2025
| return LLAvatarTracker::instance().isBuddy(owner_id); | ||
| if(LLAvatarTracker::instance().isBuddy(owner_id)) | ||
| { | ||
| LL_DEBUGS_ONCE() << "FirstClickPref & MEDIA_FIRST_CLICK_FRIEND. id: " << owner_id << LL_ENDL; |
There was a problem hiding this comment.
'debugs' and 'infos' options are the most usefull when they have a tag, so that instead of having to toggle 'debug' for multiple files individually, we can use log control to, as an example, turn on "MediaFirstClick' only and it will start working across multiple files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an error with how friendship status was handled for media first click interact purposes. It caused proceeding checks to never be run in the event it itself was run and failed.
Related Issues
Issue Link: closes #4414