4470 Include and turn on Discord SDK package #4485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
changed the title
akleshchev
force-pushed
the
andreyk/viewer_4470
branch
from
1b01778 to
3ec7103
Compare
Ansariel
reviewed
Aug 4, 2025
marchcat
approved these changes
Aug 4, 2025
Ansariel
reviewed
Aug 4, 2025
Ansariel
reviewed
Aug 4, 2025
| getChild<LLComboBox>("language_combobox")->add("System default", LLSD("default"), ADD_TOP, true); | ||
| } | ||
|
|
||
| #ifndef LL_DISCORD |
There was a problem hiding this comment.
Wouldn't it be smarter the other way around: Have it disabled by default and only enable if Discord Rich Presence support is available?
There was a problem hiding this comment.
May be, that's a quick fix I made when I saw that checkboxes are active. I might end up erasing the tab entirely.
maxim-productengine
approved these changes
Aug 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package and a bunch of fixes to make it work.