Straighten out muting to prevent echo when crossing from vivox to webrtc regions near a webrtc region boundary. #4494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Muting was a bit random in the code, so it's now been straightened out and should prevent echo.
Also, code was added to not attempt connection to non-webrtc regions in the webrtc code.
Description
Fix for issue #4419
When crossing from vivox to webrtc regions, the send connections were both being set to enabled,
which resulted in echo. This was because of poor mute state handling.
Also, the code was attempting to connect to webrtc on neighboring vivox regions.
Related Issues
Issue Link: #4419
Repro Steps:
Also, cross-webrtc-region voice should be validated.
Additional Notes