Skip to content

Conversation

roxanneskelly
Copy link
Contributor

Muting was a bit random in the code, so it's now been straightened out and should prevent echo.

Also, code was added to not attempt connection to non-webrtc regions in the webrtc code.

Description

Fix for issue #4419

When crossing from vivox to webrtc regions, the send connections were both being set to enabled,
which resulted in echo. This was because of poor mute state handling.

Also, the code was attempting to connect to webrtc on neighboring vivox regions.

Related Issues

  • Please link to a relevant GitHub issue for additional context.
    • Bug Fix: Link to an issue that includes reproduction steps and testing guidance.
    • Feature/Enhancement: Link to an issue with a write-up, rationale, and requirements.

Issue Link: #4419

Repro Steps:

  • Find two neighboring webrtc regions with yet another neighboring vivox region.
  • Log in with two viewers in one of the webrtc regions.
  • Walk one agent across the webrtc->vivox boundary and back.
  • Validate there is no voice duplication or echo.

Also, cross-webrtc-region voice should be validated.

  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

@roxanneskelly roxanneskelly added the bug Something isn't working label Aug 6, 2025
@github-actions github-actions bot added the c/cpp label Aug 6, 2025
@akleshchev akleshchev linked an issue Aug 6, 2025 that may be closed by this pull request
@roxanneskelly roxanneskelly changed the base branch from develop to release/2025.06 August 8, 2025 19:54
…rtc regions.

Muting was a bit random in the code, so it's now been straightened out and should
prevent echo.

Also, code was added to not attempt connection to non-webrtc regions in the webrtc code.
@Geenz Geenz merged commit 5b1c783 into release/2025.06 Aug 8, 2025
7 checks passed
@Geenz Geenz deleted the roxie/fix-4419 branch August 8, 2025 22:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working c/cpp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webrtc voices are doubling up

3 participants