#4334 Crash at getIsDynamic #2 #4507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A TPV dev asked to change this, so that ref wouldn't be called on some environments.
|
Reason for this change: GCC and older Clang versions will cause an incomplete type compiler error because LLViewerObject is only forward-declared at the point the overloaded constructor of LLPointer is called (in llreflectionmap.h), that internally calls the |
marchcat
approved these changes
Aug 9, 2025
|
+1 LLPointers are initialized to nullptr in their default constructor, anyway, so they do not need this default assignment in a header, or even in a class constructor. |
maxim-productengine
approved these changes
Aug 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TPV dev asked to change this, so that ref wouldn't be called on some environments.