Skip to content

Conversation

maxim-productengine
Copy link
Contributor

Use binary mode to fix certain character handling in chat logs

Copy link
Contributor

@akleshchev akleshchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's a nice idea given that files get opened up by users, can't it be encoded somehow?

@maxim-productengine
Copy link
Contributor Author

We're just reading in that mode, so it shouldn't affect opening the logs.

@maxim-productengine maxim-productengine merged commit 28b9609 into release/2025.06 Aug 11, 2025
12 checks passed
@maxim-productengine maxim-productengine deleted the maxim/2025.06-4420 branch August 11, 2025 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The presence of a U+001A character in chat log files causes transcripts to only load history up to its location.

3 participants