#4541 Cap image upload size to prevent issues #4546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchcat
approved these changes
Aug 13, 2025
marchcat
reviewed
Aug 13, 2025
|
|
||
| <string name="DefaultMimeType">none/none</string> | ||
| <string name="texture_load_dimensions_error">Can't load images larger than [WIDTH]*[HEIGHT]</string> | ||
| <string name="texture_load_dimensions_error">Can't load images larger than [PIXELS] pixels</string> |
There was a problem hiding this comment.
This might still be confusing. Maybe we could simplify it by stating the limit using only the larger dimension of the image.
There was a problem hiding this comment.
May be, but that won't be accurate either. It can be 8Kx8K it can be 32Kx2K or 1Kx64K.We are comparing an area so I think it's the most fair to show an area in the message.
maxim-productengine
approved these changes
Aug 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our limit is 256MB, so instead of limiting strictly by 8Kx8K, I'm limiting by area.