#4557 fix lags in outfit search with many outfits #4568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Aug 18, 2025
|
All outfits will be in memory from the start when they don't really need to be and inventory generaly isn't cheap. How much space does it take? Perhaps make it go over the list once (spreaded over 'on idle') when searching for the first time or at least onOpen? |
marchcat
approved these changes
Aug 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by change in bd8438f
But I prefer not just reverting it, because search in collapsed tabs will stop working - #1619
So instead of refreshing all items lists at once (for each outfit) after changing filter string - let's refresh outfit items just after fetching, which won't happen simultaneously (see LLOutfitListBase::onIdleRefreshList()).